fix: Return normalized years-months-duration #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test cases to verify that a duration returns a normalized value.
A years-months-duration should return a normalized string format. Period.getYear returns the year-component but works only if the period is normalized.
koevskinikola
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
LGTM @saig0 👍
I just have a question if we need to expand the test coverage with more test cases.
Add another test case to verify that a years-months-duration returns a normalized value.
|
Successfully created backport PR for |
|
Successfully created backport PR for |
|
Successfully created backport PR for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issues
related to #953