Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add @camunda8/sdk test + housekeeping #12

Merged
merged 6 commits into from
May 22, 2024
Merged

Add @camunda8/sdk test + housekeeping #12

merged 6 commits into from
May 22, 2024

Conversation

barmac
Copy link
Contributor

@barmac barmac commented May 21, 2024

This PR adds @camunda8/sdk test, and also updates the CI to the latest supported versions of the actions and Node.
I also updated zeebe-node and zbctl deps.

Closes #13

@barmac barmac force-pushed the test-with-sdk branch 4 times, most recently from 7fd23f0 to f053de3 Compare May 21, 2024 11:56
@barmac barmac force-pushed the test-with-sdk branch 4 times, most recently from bbcb029 to 9fb488f Compare May 21, 2024 15:52
@barmac barmac changed the title feat: add @camunda/sdk test Add @camunda/sdk test + housekeeping May 21, 2024
@barmac barmac requested a review from nikku May 21, 2024 16:00
@barmac barmac changed the title Add @camunda/sdk test + housekeeping Add @camunda8/sdk test + housekeeping May 21, 2024
@barmac barmac marked this pull request as ready for review May 21, 2024 16:03
@barmac
Copy link
Contributor Author

barmac commented May 22, 2024

I removed the Zeebe version update for now, and will provide it via a separate PR. With that change, the CI jobs wouldn't succeeed.

.github/workflows/CI.yml Outdated Show resolved Hide resolved
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🍰

@barmac barmac merged commit e54378f into main May 22, 2024
5 checks passed
@barmac barmac deleted the test-with-sdk branch May 22, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test passes the CI
2 participants