Handle ignored cves #5804
Merged
Handle ignored cves #5804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
FestiveKyle
commented
Oct 11, 2024
•
FestiveKyle
commented
- Exclude ignored CVEs from AdditionalFindings (frontend only)
- Exclude ignored CVEs from CSV export
- Log action to every verified org with claim to domain
- Log as an "UPDATE" action with updated properties of "name: , "oldValue": "ignored", "newValue": "unignored"
lcampbell2
requested changes
Nov 28, 2024
Comment on lines
+189
to
+216
| // Log activity for super admin logging | ||
| await logActivity({ | ||
| transaction, | ||
| collections, | ||
| query, | ||
| initiatedBy: { | ||
| id: user._key, | ||
| userName: user.userName, | ||
| role: 'super_admin', | ||
| }, | ||
| action: 'update', | ||
| target: { | ||
| resource: domain.domain, | ||
| resourceType: 'domain', | ||
| updatedProperties: [ | ||
| { | ||
| name: ignoredCve, | ||
| oldValue: 'unignored', | ||
| newValue: 'ignored', | ||
| }, | ||
| ], | ||
| }, | ||
| }) | ||
| } catch (err) { | ||
| console.error( | ||
| `Database error occurred when user: "${userKey}" attempted to ignore CVE "${ignoredCve}" on domain "${domainId}" during activity logs, error: ${err}`, | ||
| ) | ||
| } |
There was a problem hiding this comment.
Super admins will be able to see the other logs generated. Not sure we need this.
Comment on lines
+189
to
+216
| // Log activity for super admin logging | ||
| await logActivity({ | ||
| transaction, | ||
| collections, | ||
| query, | ||
| initiatedBy: { | ||
| id: user._key, | ||
| userName: user.userName, | ||
| role: 'super_admin', | ||
| }, | ||
| action: 'update', | ||
| target: { | ||
| resource: domain.domain, | ||
| resourceType: 'domain', | ||
| updatedProperties: [ | ||
| { | ||
| name: ignoredCve, | ||
| oldValue: 'ignored', | ||
| newValue: 'unignored', | ||
| }, | ||
| ], | ||
| }, | ||
| }) | ||
| } catch (err) { | ||
| console.error( | ||
| `Database error occurred when user: "${userKey}" attempted to unignore CVE "${ignoredCve}" on domain "${domainId}" during activity logs, error: ${err}`, | ||
| ) | ||
| } |
There was a problem hiding this comment.
Supers can see other logs, not sure this is needed
frontend/src/guidance/IgnoredCves.js
Outdated
| </Text> | ||
| ) : ( | ||
| <SimpleGrid columns={8}> | ||
| {undetectedIgnoredCves && |
There was a problem hiding this comment.
empty or null array already checked for
Comment on lines
-54
to
105
| ignoredCves: PropTypes.array.isRequired, | ||
| undetectedIgnoredCves: PropTypes.arrayOf(PropTypes.string.isRequired).isRequired, | ||
| detectedIgnoredCves: PropTypes.object.isRequired, | ||
| setActiveCveHandler: PropTypes.func.isRequired, |
There was a problem hiding this comment.
is it better to import the whole object or the individual prop types? if no performance/memory advantage this is fine
There was a problem hiding this comment.
I don't think there would be any performance loss either way. We already have these separated and the undetectedIgnoredCves are just strings since we aren't getting the vuln level from the api.
lcampbell2
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.