-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trackInfo
property to some MediaError
#1241
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4018b4d
to
5b4a67d
Compare
a2b8bcd
to
25bb55d
Compare
25bb55d
to
7b9b451
Compare
peaBerberian
added a commit
that referenced
this pull request
May 17, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
May 17, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
May 17, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jun 2, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jun 2, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jun 2, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jun 2, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jun 2, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jun 2, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jun 12, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jun 12, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jun 12, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jun 12, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jun 13, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jun 13, 2023
Add `trackInfo` property to some `MediaError`
Merged
peaBerberian
added a commit
that referenced
this pull request
Jun 14, 2023
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add `trackInfo` property to some `MediaError`
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
Add `trackInfo` property to some `MediaError`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
trackInfo
property toMediaError
errors when itscode
property is set to either:-
"NO_PLAYABLE_REPRESENTATION"
(unplayable track based on DRM policy non-compliance),-
"MANIFEST_INCOMPATIBLE_CODECS_ERROR"
(track with unsupported codec),-
"BUFFER_APPEND_ERROR"
(error while pushing a segment)-
"BUFFER_FULL_ERROR"
(error while pushing a segment which seems specifically linked to that buffer not having enough memory space left)That
trackInfo
property provides characteristics about the track linked to the error. For example, the video track's characteristics when aBUFFER_APPEND_ERROR
is linked to a video segment.The idea here mainly is to allow applications to develop much more powerful error management logic:
allowing logs of better errors. For example by knowing if an error was linked to a video or audio track and which one.
letting the application add resilience in the context of rare issues it empirically observed, that are most of the time linked to both device issues and the contents being played.
For example, if an application observes that a device's low level bug lead to the impossibility to play for some contents a video track under the PlayReady SL3000 key system, but that playing another video track do work, the application may want to reload the content after the error was received, this time filtering the problematic video track (if this example looks VERY specific, it's because it's one of the situation we did actually encounter! Issues encountered are multiple and for the most part only linked to some device, contents and DRM policies combinations).
We also thought about handling all those cases on the RxPlayer-side, but some of those appear to be very specific to the contents being played. We thus decided to also let the application develop its own code if it wants to, allowing much more flexibility and reactivity.