demo: change removed property limitVideoWidth to videoResolutionLimit #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Florent-Bouisset
added
Demo
Florent-Bouisset
force-pushed
the
demo/fix-obsolete-property-limitVideoWidth
branch
from
9b058fa to
ec3e8ac
Compare
Florent-Bouisset
force-pushed
the
demo/fix-obsolete-property-limitVideoWidth
branch
from
ec3e8ac to
5836e55
Compare
peaBerberian
reviewed
Jan 3, 2024
| case "videoElement": | ||
| videoResolutionLimitDescMsg = "The loaded video Representation will be throttled according to the given videoElement’s dimensions."; | ||
| break; | ||
| } |
There was a problem hiding this comment.
Maybe we should have a column limit to the demo.
We have one for the source but it does not seem to be enabled for the demo code.
There was a problem hiding this comment.
Apparently there is one but with the options"ignoreStrings": true that ignores lines that contains a string
I'm ok to remove this, but it should be done in a separate PR as there will be probably a lot of changes when correcting all warnings
peaBerberian
reviewed
Jan 3, 2024
| @@ -23,7 +26,7 @@ const defaultOptionsValues = { | |||
| }, | |||
| onCodecSwitch: "continue", | |||
| }, | |||
| }; | |||
| } satisfies { player: IConstructorOptions, loadVideo: ILoadVideoOptions }; | |||
|
The code looks good to me, but I would like to know what you think about adding a max column length to the demo for readability purposes |
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
…mitVideoWidth demo: change removed property limitVideoWidth to videoResolutionLimit
peaBerberian
added a commit
that referenced
this pull request
Jan 11, 2024
…mitVideoWidth demo: change removed property limitVideoWidth to videoResolutionLimit
peaBerberian
added a commit
that referenced
this pull request
Jan 15, 2024
…mitVideoWidth demo: change removed property limitVideoWidth to videoResolutionLimit
peaBerberian
added a commit
that referenced
this pull request
Jan 23, 2024
…mitVideoWidth demo: change removed property limitVideoWidth to videoResolutionLimit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Property
limitVideoWidthhas been removed in the API for v4.0.0 but the changes was not reflected in the demo.This PR change this obsolete property by the new
videoResolutionLimitin the demo.