Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): fix ts error in global declaration #1346

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

Florent-Bouisset
Copy link
Collaborator

using global import, ex: __ENVIRONMENT__ in the demo/full folder didn't work because there is a demo/full/tsconfig file that has more priority than src/tsconfig in the demo/full folder. The fix was to add the global import file in the demo/full/tsconfig

using global import, ex: `__ENVIRONMENT__` in the `demo/full` folder
didn't work because there is a `demo/full/tsconfig` file that has more
priority than `src/tsconfig` in the `demo/full` folder.
The fix was to add the global import file in the `demo/full/tsconfig`
@Florent-Bouisset Florent-Bouisset added the bug This is an RxPlayer issue (unexpected result when comparing to the API) label Jan 2, 2024
@peaBerberian peaBerberian merged commit 88e9b44 into next-v4 Jan 3, 2024
5 checks passed
peaBerberian added a commit that referenced this pull request Jan 3, 2024
fix(demo): fix ts error in global declaration
@peaBerberian peaBerberian added this to the 4.0.0-rc.1 milestone Jan 4, 2024
peaBerberian added a commit that referenced this pull request Jan 11, 2024
fix(demo): fix ts error in global declaration
peaBerberian added a commit that referenced this pull request Jan 11, 2024
fix(demo): fix ts error in global declaration
peaBerberian added a commit that referenced this pull request Jan 15, 2024
fix(demo): fix ts error in global declaration
peaBerberian added a commit that referenced this pull request Jan 23, 2024
fix(demo): fix ts error in global declaration
@peaBerberian peaBerberian deleted the demo/fix-ts-config branch February 7, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This is an RxPlayer issue (unexpected result when comparing to the API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants