DRM: In a singleLicensePer content mode, blacklist the first kid if not encountered #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot encountered We had a bug in our implementation of the `singleLicensePer` API (not yet released, hopefully), where we would not fallback from a quality linked to a key id not found in the licence, only if that key id was the first encountered. This is because the check we (I) added to do that only did it on subsequent key ids, not the first one that triggered the license-fetching process. I tried to add a fix but it is not as simple as it looks, because if we're doing that in a `singleLicensePer`: "content"` mode, why not always (as it would make sense to always fallback when the wanted key id is not found in the corresponding license). However I prefer not to do that due to both not break the API and the possible compatibilities issues as explained in the code. So I was left doing it only if `singleLicensePer` was not set to the default value, and putting that code in `eme_manager.ts` instead of where I would have preferred to put it, initially, in `check_key_statuses.ts`.
peaBerberian
added
bug
grenault73
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug in our implementation of the
singleLicensePerAPI (not yet released, hopefully), where we would not fallback from a quality linked to a key id not found in the licence, only if that key id was the first encountered.This is because the check we (I) added to do that only did it on subsequent key ids, not the first one that triggered the license-fetching process.
I tried to add a fix but it is not as simple as it looks, because if we're doing that in a
singleLicensePer: "content"` mode, why notalways (as it would make sense to always fallback when the wanted key id is not found in the corresponding license).
However I prefer not to do that due to both not break the API and the possible compatibilities issues as explained in the code.
So I was left doing it only if
singleLicensePerwas not set to the default value, and putting that code ineme_manager.tsinstead of where I would have preferred to put it, initially, incheck_key_statuses.ts.