Allow passing char to some joker.string functions #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clojure isn't entirely consistent with this, but it is common to allow passing a char as a secondary argument in functions that operate on strings (e.g. `join`, `replace`, `index-of`)
|
I like it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clojure isn't entirely consistent with this, but it is common to allow passing a char as a secondary argument in functions that operate on strings (e.g.
join,replace,index-of).Adding a
Stringablepseudo-type seemed like the most straightforward way to accomplish this, but it does feel a little awkward, since all the other types have generatedEnsureandAssertfunctions. I'd be open to doing this another way if you'd prefer.