Disable maven exclusion semantics in Spring Dependency Management Plugin #940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candrews
force-pushed
the
disable-spring-dependency-management-maven-exclusion-semantics
branch
from
332845c to
6f1e832
Compare
Starting with Spring Dependency Management Plugin version 1.1.0, invalid
POMs cause the plugin to fail. Unfortunately, Sonar has dependencies
that have invalid POMs, and it doesn't appear that Sonar is going to
change to use dependencies with valid POMs any time soon.
Therefore, in order to continuing using the name.remal.sonarlint plugin,
there are only two options:
1. Downgrade Sonar to a version that has dependencies all with valid
POMs. That could be done by adding a dependency on:
`sonarlintCorePlugins("org.sonarsource.java:sonar-java-plugin:7.18.0.31443")`
However, it's not ideal to be stuck on an old version for an
indeterminate amount of time.
2. Disable Spring Dependency Management Plugin's new maven exclusion
semantics. There doesn't appear to be a downside for this project in
doing so.
See: spring-gradle-plugins/dependency-management-plugin#365
See: https://community.sonarsource.com/t/sonar-java-plugin-has-dependencies-with-invalid-poms/96334/6
candrews
force-pushed
the
disable-spring-dependency-management-maven-exclusion-semantics
branch
from
6f1e832 to
4ab1069
Compare
…-exclusion-semantics
candrews
deleted the
disable-spring-dependency-management-maven-exclusion-semantics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Spring Dependency Management Plugin version 1.1.0, invalid POMs cause the plugin to fail. Unfortunately, Sonar has dependencies that have invalid POMs, and it doesn't appear that Sonar is going to change to use dependencies with valid POMs any time soon.
Therefore, in order to continuing using the name.remal.sonarlint plugin, there are only two options:
sonarlintCorePlugins("org.sonarsource.java:sonar-java-plugin:7.18.0.31443")However, it's not ideal to be stuck on an old version for an indeterminate amount of time.See: spring-gradle-plugins/dependency-management-plugin#365
See: https://community.sonarsource.com/t/sonar-java-plugin-has-dependencies-with-invalid-poms/96334/6