Message Event Custom Data

[maennchen]

It would be nice to have a possibility to add custom data to the candy:view.message.before-show Event and then receive this in candy:view.message.after-show.

This would give the possibility to let plugins change the event data and handle them on after-show in a notifications-plugin for example.

[maennchen]

PS: I'd like to let the modifyme plugin add a custom parameter indicating it's a message which is for me and handle this different from normal messages in the notifications plugin.

[mweibel]

This could be achieved by restructuring the event handling a bit (this might required to change the plugins a bit, sadly).
As I started implementing the new event system, I didn't know that a callback can actually return something and this will be given back to the trigger of the event. Therefore we could, instead of doing something strange with the events, just use the return value of the trigger.

This however, would require also that the plugin authors are aware that they need to return the event params again. Don't know if that's a good solution.

[maennchen]

Can't we just do this:

$(Candy).on('candy:view.message.before-show', function(event, args) {
    args.mCustomKey = 'myCustomValue';
});

[maennchen]

Have a look at my fiddle ;-)

http://jsfiddle.net/W5Cpt/

I think this way the plugins have nothing to change...

[maennchen]

Thx, now I can make some improvements on the notification plugins.

[mweibel]

Maybe first based in the dev branch of the plugins repo until 1.6.1 is release

On Thu, Jan 23, 2014 at 7:01 PM, Jonatan Männchen
[email protected] wrote:

Thx, now I can make some improvements on the notification plugins.

Reply to this email directly or view it on GitHub:
#215 (comment)

[maennchen]

Have a look at candy-chat/candy-plugins#75 :-)