This repository has been archived by the owner on Nov 21, 2024. It is now read-only.
Added new event "candy:core:chat:message:other". #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…abber.Message that is triggered when messaged are received without the type attribute.
|
Looks good, thanks! |
mweibel
added a commit
that referenced
this pull request
Mar 5, 2014
Added new event "candy:core:chat:message:other".
|
Here was a plugin I was able to write because of this change. It Spark chat users invite users into their already created rooms with or without Candy user interactions. https://github.com/joshuah/candyland/tree/master/spark-room-invites |
|
Neat :) Do you want to publish it to candy-plugins? |
|
Maybe first to the dev branch as well, until there's a newer version. |
|
I will run it in production for a few weeks little first. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new event candy:core:chat:message:other when messages arrive without a type attribute. This is useful to allow plugins that can detect MUC invites from other clients such as Spark.
http://xmpp.org/extensions/xep-0045.html#invite
Hope I did this right this time...