Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(package): create a dispatch file if none exists #1898

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

lengau
Copy link
Collaborator

@lengau lengau commented Sep 11, 2024

This creates a dispatch file during the post-prime step if there is no existing dispatch file and there isn't a hooks directory.

Progress towards #1813

@lengau lengau force-pushed the work/1873/CRAFT-3361/dispatch-file branch 2 times, most recently from dd7c864 to a5ddb82 Compare September 17, 2024 15:58
This creates a dispatch file during the post-prime step if there
is no existing dispatch file and there isn't a hooks directory.

Fixes #1813
@lengau lengau force-pushed the work/1873/CRAFT-3361/dispatch-file branch from a5ddb82 to c779194 Compare September 17, 2024 20:03
@lengau lengau marked this pull request as ready for review September 18, 2024 20:55
@lengau lengau requested review from dariuszd21 and mr-cal September 18, 2024 20:55
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sorry for the delay in reviewing

Copy link
Contributor

@dariuszd21 dariuszd21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@lengau lengau enabled auto-merge September 25, 2024 12:43
@lengau lengau disabled auto-merge September 26, 2024 15:49
@lengau lengau merged commit b4f91c7 into main Sep 26, 2024
19 of 20 checks passed
@lengau lengau deleted the work/1873/CRAFT-3361/dispatch-file branch September 26, 2024 15:50
@lengau
Copy link
Collaborator Author

lengau commented Sep 26, 2024

Force-merging, as test failures are due to: RobertCraigie/pyright-python#304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants