feat: support multi-base recipes #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-cal
force-pushed
the
work/CRAFT-3721-multi-base-support
branch
from
f5e1f1c to
292d9fc
Compare
lengau
reviewed
Dec 18, 2024
lengau
reviewed
Dec 18, 2024
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
mr-cal
force-pushed
the
work/CRAFT-3721-multi-base-support
branch
from
292d9fc to
750daa8
Compare
lengau
reviewed
Dec 19, 2024
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
Signed-off-by: Callahan Kovacs <[email protected]>
|
Update: it was a transient store-side failure |
cmatsuoka
approved these changes
Dec 19, 2024
lengau
approved these changes
Dec 19, 2024
lengau
added a commit
that referenced
this pull request
Jan 18, 2025
Adds [reference](https://canonical-charmcraft--2080.com.readthedocs.build/en/2080/reference/platforms/) and [how-to](https://canonical-charmcraft--2080.com.readthedocs.build/en/2080/howto/build-guides/platforms/) documentation for platforms, bases, and architectures in Charmcraft, including information on the new [multi-base support](#2054). Fixes #2009 (CRAFT-3720) --------- Signed-off-by: Callahan Kovacs <[email protected]> Co-authored-by: Alex Lowe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for multi-base recipes with the
platformskeyword.Internally, this moves to a new practice where the application stops modifying project data before passing the it to craft-platforms. This will ensure consistent processing by charmcraft and by launchpad.
Documentation is coming soon via canonical/craft-platforms#75 and #2009.
To summarize the usage,
baseandbuild-baseare removed from the project and the base is encoded into the platform.Platforms can be defined in a shorthand notation:
Or they can be defined in standard form:
Fixes #1789
Fixes #2008
Creates canonical/craft-platforms#85
Found during implementation canonical/craft-platforms#80
(CRAFT-3718)