Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove message to manually upgrade data-plane #259

Conversation

rgildein
Copy link
Contributor

Since the dev/data-plane is introducing upgrade for data-plane there is no reason to left this message here.

fixes: #140

Since the dev/data-plane is introducing upgrade for data-plane
there is no reason to left this message here.

fixes: canonical#140
@rgildein rgildein added the bug Something isn't working label Feb 27, 2024
@rgildein rgildein self-assigned this Feb 27, 2024
@rgildein rgildein requested review from a team, Pjack, aieri, agileshaw and jneo8 February 27, 2024 10:00
cou/cli.py Outdated Show resolved Hide resolved
Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the docstring of analyze_and_plan function?

@rgildein
Copy link
Contributor Author

analyze_and_plan

I do not like this redundancy (type hinting in docstring and real one).

@rgildein rgildein requested a review from agileshaw February 28, 2024 09:29
Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgildein rgildein merged commit 2f9da2a into canonical:dev/data-plane Feb 28, 2024
4 checks passed
@rgildein rgildein deleted the bug/BSENG-1675/remove-manual-upgrade-warning branch February 28, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants