-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove message to manually upgrade data-plane #259
remove message to manually upgrade data-plane #259
Conversation
Since the dev/data-plane is introducing upgrade for data-plane there is no reason to left this message here. fixes: canonical#140
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also update the docstring of analyze_and_plan
function?
I do not like this redundancy (type hinting in docstring and real one). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Since the dev/data-plane is introducing upgrade for data-plane there is no reason to left this message here.
fixes: #140