Bash completion for upgrade-groups #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added bash completion for data-plane, control-plane and hypervisors - added --machine and --availability-zone for hypervisors - removed supressed help messages
gabrielcocenza
requested review from
a team,
Pjack,
aieri,
agileshaw,
jneo8 and
rgildein
agileshaw
suggested changes
Feb 29, 2024
There was a problem hiding this comment.
Some issues with the bash completion. Here are my test results:
# upgrade child command should not show up after control-plane is specified
ubuntu@machine:~/sunbeam-charms$ cou plan control-plane
--backup --help --model --no-backup --quiet --verbose control-plane data-plane hypervisors
# upgrade child command should not show up after data-plane is specified
ubuntu@machine:~/sunbeam-charms$ cou plan control-plane
--backup --help --model --no-backup --quiet --verbose control-plane data-plane hypervisors
# Ideally should also show common args like `--help`, `--quiet`, etc
ubuntu@machine:~/sunbeam-charms$ cou plan hypervisors --
--availability-zone --machine
Feel free to refer to the code I shared in #63 (not up to date and may not be perfect, but hopefully would help you with your approach)
- fix to child commands have common options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #63