Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the plan generation of Hypervisor to the machines passed. #270

Merged
merged 5 commits into from
Mar 6, 2024
Merged

Limit the plan generation of Hypervisor to the machines passed. #270

merged 5 commits into from
Mar 6, 2024

Conversation

gabrielcocenza
Copy link
Member

  • currently the hypervisor is generating the plan for all hypervisor machines not considering the cli filter that can be specific to some machines or azs
  • changed the eq method of HypervisorGroup to also compare the app_units

@gabrielcocenza
Limit the plan generation of Hypervisor to the machines passed.
effebe2 
- currently the hypervisor is generating the plan for all hypervisor
  machines not considering the cli filter that can be specific to
  some machines or azs
- changed the eq method of HypervisorGroup to also compare the
  app_units
@gabrielcocenza gabrielcocenza self-assigned this Mar 1, 2024
@gabrielcocenza gabrielcocenza requested review from a team, Pjack, aieri, agileshaw, jneo8 and rgildein March 1, 2024 18:09
rgildein
rgildein suggested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it's looks good, only some small changes required.

cou/steps/hypervisor.py Outdated Show resolved Hide resolved
cou/steps/hypervisor.py Outdated Show resolved Hide resolved
cou/steps/hypervisor.py Outdated Show resolved Hide resolved
cou/steps/plan.py Outdated Show resolved Hide resolved
tests/unit/steps/test_hypervisor.py Outdated Show resolved Hide resolved
tests/unit/steps/test_hypervisor.py Outdated Show resolved Hide resolved
tests/unit/steps/test_hypervisor.py Show resolved Hide resolved
tests/unit/steps/test_hypervisor.py Outdated Show resolved Hide resolved
@gabrielcocenza gabrielcocenza requested a review from rgildein March 4, 2024 14:07
rgildein
rgildein approved these changes Mar 4, 2024
View reviewed changes
cou/steps/hypervisor.py Show resolved Hide resolved
cou/steps/plan.py Outdated Show resolved Hide resolved
agileshaw
agileshaw suggested changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just one suggestion.

cou/steps/plan.py Outdated Show resolved Hide resolved
This was referenced Mar 5, 2024
Closed
Closed
agileshaw
agileshaw approved these changes Mar 5, 2024
View reviewed changes
cou/steps/plan.py Outdated Show resolved Hide resolved
@gabrielcocenza gabrielcocenza merged commit f2b7ee5 into canonical:dev/data-plane Mar 6, 2024
4 checks passed
@github-actions github-actions bot mentioned this pull request Mar 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agileshaw agileshaw agileshaw approved these changes

@rgildein rgildein rgildein approved these changes

@Pjack Pjack Awaiting requested review from Pjack

@aieri aieri Awaiting requested review from aieri

@jneo8 jneo8 Awaiting requested review from jneo8

Assignees

@gabrielcocenza gabrielcocenza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabrielcocenza @agileshaw @rgildein