Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce env vars to define idle state timeout #271

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Introduce env vars to define idle state timeout #271

merged 3 commits into from
Mar 5, 2024

Conversation

gabrielcocenza
Copy link
Member

  • COU_STANDARD_IDLE_TIMEOUT for standard OpenStackApplication
  • COU_LONG_IDLE_TIMEOUT for apps that take more time to upgrade
  • updated documentation

Closes #269

@gabrielcocenza
Introduce env vars to define idle state timeout
b69f00c 
- COU_STANDARD_IDLE_TIMEOUT for standard OpenStackApplication
- COU_LONG_IDLE_TIMEOUT for apps that take more time to upgrade
- updated documentation
@gabrielcocenza gabrielcocenza requested review from a team, Pjack, aieri, agileshaw, jneo8 and rgildein March 1, 2024 20:24
@gabrielcocenza gabrielcocenza self-assigned this Mar 1, 2024
rgildein
rgildein suggested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please choose your own names, not those I provided in my examples.

cou/apps/auxiliary.py Outdated Show resolved Hide resolved
cou/apps/base.py Outdated Show resolved Hide resolved
@gabrielcocenza gabrielcocenza requested a review from rgildein March 4, 2024 15:28
agileshaw
agileshaw approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some nit suggestions

docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
cou/apps/base.py Outdated Show resolved Hide resolved
aieri
aieri suggested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@aieri aieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good, I just suggested a rewording of the documentation

docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
docs/reference/environment-variables.rst Outdated Show resolved Hide resolved
@gabrielcocenza gabrielcocenza requested a review from aieri March 4, 2024 18:27
agileshaw
agileshaw approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@agileshaw agileshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we merge this directly to main though?

@rgildein
Copy link
Contributor

rgildein commented Mar 4, 2024

LGTM. Should we merge this directly to main though?

We need to create separate PR for margin to main, or if we want to merge it also to dev/data-plane. Not sure if we want to create it like that, since we are using "squash and merge" it will mean that we have two different commits doing same thing.... 🤔

@aieri aieri linked an issue Mar 5, 2024 that may be closed by this pull request
Reach the idle state timeout - would be nice if it was configurable #269
Closed
This was referenced Mar 5, 2024
Closed
Closed
@gabrielcocenza gabrielcocenza merged commit 20f0476 into canonical:dev/data-plane Mar 5, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Mar 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aieri aieri aieri approved these changes

@agileshaw agileshaw agileshaw approved these changes

@rgildein rgildein rgildein approved these changes

@Pjack Pjack Awaiting requested review from Pjack

@jneo8 jneo8 Awaiting requested review from jneo8

Assignees

@gabrielcocenza gabrielcocenza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reach the idle state timeout - would be nice if it was configurable
4 participants
@gabrielcocenza @rgildein @aieri @agileshaw