COUUnit able to evaluate its current OpenStackRelease

[gabrielcocenza]

• move the responsability to evaluate OpenStackRelease from units to the COUUnit instead of the Application
• adapt unit tests

[gabrielcocenza]

With those changes it will be easier to not include units of nova-compute and colocated OpenStack apps that already got upgraded for a certain target

[rgildein]

I do not see the benefit from this approach, can you explain it more?
Like this we are mixing logic of OpenStackApplication and COUApplication, let say we have model with some apps (e.g. telegraf), which are not related with OpenStack anyhow, and we do app.os_release. We will get an error saying that there is no compatible version, which is confusing. I know we should never run os_release on not OpenStackApplication.

[gabrielcocenza]

Like this we are mixing logic of OpenStackApplication and COUApplication, let say we have model with some apps (e.g. telegraf), which are not related with OpenStack anyhow, and we do app.os_release. We will get an error saying that there is no compatible version, which is confusing. I know we should never run os_release on not OpenStackApplication.

Good point, I didn't think about this issue of mixing. What I'm currently missing is to easily access the OpenStackRelease just having the Units objects and not the Application itself. Maybe we can "overwrite" the units in the factory once we know that the application is supported.

[rgildein]

I do not think that this will be needed, so I'm closing it. Feel free to re-open it, if you come with another approach.