-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(24.04): Add SDF for libgl1
and dependencies
#474
base: ubuntu-24.04
Are you sure you want to change the base?
Conversation
Diff of dependencies: slices/libgl1-mesa-dri.yaml@@ -1,6 +1,5 @@
libc6
libdrm-amdgpu1
-libdrm-intel1
libdrm-nouveau2
libdrm-radeon1
libdrm2 |
0d8dccc
to
bbcae14
Compare
bbcae14
to
a066c34
Compare
a066c34
to
3695e67
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I just have one question about the libsensors-config package.
slices: | ||
config: | ||
contents: | ||
/etc/sensors3.conf: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the directory /etc/sensors.d/
? It may be expected to exist since there is a .placeholder
file in that path.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I added it with {make: true}
to have chisel create the empty directory, unless you think it is better to include the empty .placeholder
file in the slice.
Proposed changes
Add SDF for
libgl1
and dependencies.See canonical/chisel#93 for the dependency diff.
Related issues/PRs
Forward porting
24.10 PR: #475
Checklist
Additional Context