Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): Add SDF for libgl1 and dependencies #474

Open
wants to merge 2 commits into
base: ubuntu-24.04
Choose a base branch
from

Conversation

HadrienPatte
Copy link
Contributor

@HadrienPatte HadrienPatte commented Jan 26, 2025

Proposed changes

Add SDF for libgl1 and dependencies.

See canonical/chisel#93 for the dependency diff.

Related issues/PRs

Forward porting

24.10 PR: #475

Checklist

Additional Context

Copy link

github-actions bot commented Jan 26, 2025

Diff of dependencies:

slices/libgl1-mesa-dri.yaml
@@ -1,6 +1,5 @@
 libc6
 libdrm-amdgpu1
-libdrm-intel1
 libdrm-nouveau2
 libdrm-radeon1
 libdrm2

@HadrienPatte HadrienPatte marked this pull request as ready for review January 26, 2025 03:08
Copy link

@clay-lake clay-lake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just have one question about the libsensors-config package.

slices:
config:
contents:
/etc/sensors3.conf:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the directory /etc/sensors.d/ ? It may be expected to exist since there is a .placeholder file in that path.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I added it with {make: true} to have chisel create the empty directory, unless you think it is better to include the empty .placeholder file in the slice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants