remove unused ManifestSlices

internal/manifest/manifest.go

@@ -183,17 +183,10 @@ func FindPaths(slices []*setup.Slice) map[string][]*setup.Slice {
 type WriteOptions struct {
 	PackageInfo []*archive.PackageInfo
 	Selection   []*setup.Slice
-	// Map manifest path to all the slices that declare it. See
-	// manifest.FindPaths.
-	ManifestSlices map[string][]*setup.Slice
-	Report         *Report
+	Report      *Report
 }
 
 func Write(options *WriteOptions, writer io.Writer) error {
-	if len(options.ManifestSlices) == 0 {
-		// Nothing to do.
-		return nil
-	}
 	dbw := jsonwall.NewDBWriter(&jsonwall.DBWriterOptions{
 		Schema: Schema,
 	})
@@ -270,6 +263,9 @@ func manifestAddSlices(dbw *jsonwall.DBWriter, slices []*setup.Slice) error {
 }
 
 func manifestAddReport(dbw *jsonwall.DBWriter, report *Report) error {
+	if report == nil {
+		return nil
+	}
 	for _, entry := range report.Entries {
 		sliceNames := []string{}
 		for slice := range entry.Slices {

internal/manifest/manifest_test.go

@@ -357,10 +357,6 @@ func (s *S) TestGenerateManifests(c *C) {
 	}
 
 	options := &manifest.WriteOptions{
-		ManifestSlices: map[string][]*setup.Slice{
-			"/dir/manifest.wall":       {slice1},
-			"/other-dir/manifest.wall": {slice1},
-		},
 		PackageInfo: packageInfo,
 		Selection:   []*setup.Slice{slice1, slice2},
 		Report:      report,

internal/slicer/slicer.go

@@ -367,10 +367,9 @@ func generateManifests(targetDir string, selection *setup.Selection,
 	}
 	defer w.Close()
 	writeOptions := &manifest.WriteOptions{
-		ManifestSlices: manifestSlices,
-		PackageInfo:    pkgInfos,
-		Selection:      selection.Slices,
-		Report:         report,
+		PackageInfo: pkgInfos,
+		Selection:   selection.Slices,
+		Report:      report,
 	}
 	err = manifest.Write(writeOptions, w)
 	return err