Added explicit configuration option storage-redirect-disable
#71
+84
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
reviewed
Sep 13, 2024
| uses: canonical-web-and-design/Inclusive-naming/.github/workflows/woke.yaml@main | ||
| uses: canonical/Inclusive-naming/.github/workflows/woke.yaml@main |
There was a problem hiding this comment.
thanks... this move has affected us all..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added charm configuration option
storage-redirect-disablewhich allows to configure distribution behavior for s3/swift object storages. We need to provide such an option because this charm could be deployed with private object storage(e.g. CEPH RADOS object storage) and in this case user can't download any artifacts from the registry.In previous versions of charm storage redirect was disabled implicitly for swift storage only. Now behavior of charm should be more clear and understandable. The default behavior for swift wasn't changed.
+ added unit tests and fixed linter issues
LP bug: https://bugs.launchpad.net/layer-docker-registry/+bug/2080349