Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add LVM Interfaces #86

Closed
sempervictus opened this issue Jul 14, 2024 · 1 comment · Fixed by #94
Closed

Feature Request: Add LVM Interfaces #86

sempervictus opened this issue Jul 14, 2024 · 1 comment · Fixed by #94
Labels
enhancement New feature or request triaged Triaged to be addressed in a given cycle

Comments

@sempervictus
Copy link

The client supports RAID and BCache sets but does not seem to handle LVM (or ZFS) layouts. There are currently requests up on the TF provider issue tracker to handle these resources/data types which would first mandate implementation at this layer.

@skatsaounis
Copy link
Collaborator

Hi @sempervictus. It seems that to support LVM storage layout we are missing gomaasclient support for the following endpoints:

  • DELETE /MAAS/api/2.0/nodes/{system_id}/volume-group/{id}/ -- Delete volume group
  • GET /MAAS/api/2.0/nodes/{system_id}/volume-group/{id}/ -- Read a volume group
  • PUT /MAAS/api/2.0/nodes/{system_id}/volume-group/{id}/ -- Update a volume group
  • POST /MAAS/api/2.0/nodes/{system_id}/volume-group/{id}/op-create_logical_volume -- Create a logical volume
  • POST /MAAS/api/2.0/nodes/{system_id}/volume-group/{id}/op-delete_logical_volume -- Delete a logical volume
  • GET /MAAS/api/2.0/nodes/{system_id}/volume-groups/ -- List all volume groups
  • POST /MAAS/api/2.0/nodes/{system_id}/volume-groups/ -- Create a volume group

As for ZFS, gomaasclient already supports:

  • BlockDevicePartitions.Create to create a partition
  • BlockDevicePartition.Format to format the partition with fsType=zfsroot
  • BlockDevicePartition.Mount to mount the partition to e.g. / with mountPoint=/

I am using this issue to track the support for Volume Groups / Volume Group Logical Volumes

Thank you for opening it 🙂

@skatsaounis skatsaounis added enhancement New feature or request triaged Triaged to be addressed in a given cycle labels Jul 31, 2024
summerwind added a commit to summerwind/gomaasclient that referenced this issue Aug 3, 2024
summerwind added a commit to summerwind/gomaasclient that referenced this issue Aug 3, 2024
summerwind added a commit to summerwind/gomaasclient that referenced this issue Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Triaged to be addressed in a given cycle
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants