Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Machines.Get example in README #85

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

gnuoy
Copy link
Contributor

@gnuoy gnuoy commented Jul 5, 2024

It seems as part of 608640d the signature of Machines.Get changed breaking the example in the README.md. This change fixes the example.

It seems as part of #608640d1 the signature of Machines.Get changed
breaking the example in the README.md. This change fixes the example.
@gnuoy
Copy link
Contributor Author

gnuoy commented Jul 8, 2024

I have updated my LP profile, so hopefully the CI failure should now be fixed

@troyanov
Copy link
Member

troyanov commented Jul 8, 2024

I have updated my LP profile, so hopefully the CI failure should now be fixed

@gnuoy did you already sign the CLA? (maybe our automation is broken)
https://ubuntu.com/legal/contributors/agreement

CLA check actually checks if a user is a member of the following group

@gnuoy
Copy link
Contributor Author

gnuoy commented Jul 8, 2024

I have updated my LP profile, so hopefully the CI failure should now be fixed

@gnuoy did you already sign the CLA? (maybe our automation is broken) https://ubuntu.com/legal/contributors/agreement

CLA check actually checks if a user is a member of the following group

Hi @troyanov, thanks for the clarification. I've just signed the CLA.

@gnuoy
Copy link
Contributor Author

gnuoy commented Jul 9, 2024

fwiw I've signed the CLA but I'm not showing up in that LP group.

@troyanov
Copy link
Member

troyanov commented Jul 9, 2024

fwiw I've signed the CLA but I'm not showing up in that LP group.

Sorry, there was some turbulence in our automation. Should be fixed now!

Thanks a lot for the contribution @gnuoy

@troyanov troyanov self-requested a review July 9, 2024 14:00
@troyanov troyanov merged commit 26cddf4 into canonical:master Jul 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants