fix: add ability to pass query params to Get() dns resources and records #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
Not sure why the check failed, I signed the CLA earlier today. I've resigned it just in case. |
|
Hi @arturshadnik and thanks for the contribution! It could be that something is not being properly updated on our side. I will check if there are any issues with the CLA check functionality (could be a stale cache). |
|
As you can observe, the issue with cla-check is gone. However, it seems that you need to align the fields inside the structs. You can try with something like this snippet. |
skatsaounis
requested changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNSResourcesandDNSResourceRecordsGet() apis to accept query params as specified in the API docs.Resolves GH: #89