Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install axios #41

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Install axios #41

merged 1 commit into from
Apr 12, 2024

Conversation

beliaev-maksim
Copy link
Member

@beliaev-maksim beliaev-maksim commented Apr 12, 2024 •
edited
Loading

install axios and commit all node_modules content

simondeziel
simondeziel approved these changes Apr 12, 2024
View reviewed changes
Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. If that's easy for you, it'd be nice to have HTTPS used to contact the remote server, thanks.

@beliaev-maksim
Copy link
Member Author

current there is no TLS, we will move to the right place beginning of the next cycle

@beliaev-maksim
commit node_modules
2981c48 
install axios as dep
@beliaev-maksim beliaev-maksim mentioned this pull request Apr 12, 2024
Merged
seb128
seb128 approved these changes Apr 12, 2024
View reviewed changes
Copy link

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it!

@seb128 seb128 merged commit 541d170 into canonical:main Apr 12, 2024
2 checks passed
@beliaev-maksim beliaev-maksim deleted the install_axios branch April 12, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simondeziel simondeziel simondeziel approved these changes

@seb128 seb128 seb128 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beliaev-maksim @simondeziel @seb128