Migrate to pydantic 2 #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upils
force-pushed
the
migrate-to-pydantic-2
branch
from
a978195 to
ce018d4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
+ Coverage 97.51% 98.06% +0.55%
==========================================
Files 20 20
Lines 482 414 -68
Branches 74 60 -14
==========================================
- Hits 470 406 -64
+ Misses 9 7 -2
+ Partials 3 1 -2 ☔ View full report in Codecov by Sentry. |
upils
force-pushed
the
migrate-to-pydantic-2
branch
4 times, most recently
from
12e2666 to
85641a5
Compare
|
@cmatsuoka @tigarmo A quick review of this from the craft team would be greatly appreciated if you can spare some time! |
Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
- remove duplicated validation - Use new ConfigDict - replace validators with field_validator and model_validator - adapt to new errors - adapt to new craft_parts Plugin - use model_dump - rely on model_validate to unmarshal objects Signed-off-by: Paul Mars <[email protected]>
Apply the same fix as in canonical/craft-parts#795 Signed-off-by: Paul Mars <[email protected]>
Signed-off-by: Paul Mars <[email protected]>
upils
force-pushed
the
migrate-to-pydantic-2
branch
from
f5e5c7b to
6d47eb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate to pydantic V2 and adapt to new craft libraries.
Fixes: FR-8917