return model summaries with new model owner #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor ModelInfo slightly to use a separate function where we merge the juju model info with JIMM specific data - refactor the test for ModelInfo to reduce duplication - tweak the test dialer to have less surprising behavior
kian99
force-pushed
the
return-model-info-with-jimm-data
branch
from
d0a5be3 to
ec44b6b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to fix an inconsistency in JIMM between the
ModelInfoandModelSummariesmethods. The latter takes each JIMM dbmodel.Model object that a user has access to and converts into into a model summary.The former makes an API call to the Juju controller and returns the modelInfo object to the user after replacing some JIMM specific fields like
userAccess.One issue is that the modelOwner field was not being replaced in the
modelInfocall. But this value is unique when using JIMM. In a similar vein, the modelOwner may be different in JIMM versus the Juju controller, particularly when importing a model.Full list of changes:
Partially fixes CSS-10592
Engineering checklist
Check only items that apply