Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix token permissions alert #998

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

HomayoonAlimohammadi
Copy link
Contributor

@HomayoonAlimohammadi HomayoonAlimohammadi commented Jan 23, 2025

Fixes https://github.com/canonical/k8s-snap/security/code-scanning/469

Overview

This PR removes the top level write permission and grants job level write permissions when necessary.

Note

Does not need a backport since the job manifest is not available in release-1.32.

@HomayoonAlimohammadi HomayoonAlimohammadi requested a review from a team as a code owner January 23, 2025 07:56
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HomayoonAlimohammadi HomayoonAlimohammadi merged commit 508b08c into main Jan 23, 2025
30 checks passed
@HomayoonAlimohammadi HomayoonAlimohammadi deleted the fix-token-permissions-alert branch January 23, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants