snapcraft: Fix LXD snap bash completions #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simondeziel
previously approved these changes
Dec 20, 2024
tomponline
added a commit
to canonical/lxd
that referenced
this pull request
Dec 20, 2024
This PR fixes the logic in `cmpRemotes` to ensure remotes are contextually completed correctly based on the current remote. While testing canonical/lxd-pkg-snap#674, I noticed that the `local` remote was not completed while on a different remote.
This commit changes the permissions, location, and file extension of the `lxc` bash completions script to ensure correct execution. Signed-off-by: Kadin Sayani <[email protected]>
kadinsayani
force-pushed
the
latest-edge
branch
from
fcda538 to
8fdccb7
Compare
simondeziel
approved these changes
Jan 6, 2025
tomponline
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes canonical/lxd#14635, canonical/lxd#14690 and canonical/lxd#14648.
This PR changes the permissions, location, and file extension of the
lxcbash completions script to ensure correct execution. Thebash-completionspackage is also added to the snap stage packages.