Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport shmounts (4.0-edge) #687

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

simondeziel
Copy link
Member

No description provided.

stgraber and others added 4 commits January 15, 2025 15:57
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit 181849d)
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit 1883742)
Signed-off-by: Simon Deziel <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]>
(cherry picked from commit 97af0f5)
Signed-off-by: Simon Deziel <[email protected]>
Make sure to terminate the forked off mount namespace capture helper, otherwise
the child will continue execution of the remaining setup code and thus cause a
race with the parent which occasionally manifests itself with the
/var/snap/lxd/common/shmounts being missing from the parennt's mount namespace
after it has switched back to the moutn ns of pid 1.

Signed-off-by: Maciej Borzecki <[email protected]>
(cherry picked from commit ab8c018)
Signed-off-by: Simon Deziel <[email protected]>
@simondeziel simondeziel marked this pull request as ready for review January 15, 2025 21:45
@simondeziel
Copy link
Member Author

@tomponline with this PR, I was able to confirm https://bugs.launchpad.net/ubuntu/+source/snapd/+bug/1989603 is fixed.

Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Once the daily lxd-ci tests pass can you put up a PR for 4.0/candidate with these too please.

@tomponline tomponline merged commit 2b6ed9b into canonical:4.0-edge Jan 16, 2025
4 checks passed
@simondeziel simondeziel deleted the shmounts-4.0-edge branch January 16, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants