lxd: Update logic for project config patch #13786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomponline
reviewed
Jul 19, 2024
|
@boltmark Please can you add a test for updating projects via PATCH, see You can add it to the projects.sh file in the |
Signed-off-by: Mark Bolton <[email protected]>
boltmark
force-pushed
the
fix-project-patch
branch
from
941e589 to
8ac9fd8
Compare
Signed-off-by: Mark Bolton <[email protected]>
boltmark
force-pushed
the
fix-project-patch
branch
from
8ac9fd8 to
b44b461
Compare
|
@tomponline Thanks for the comments. I have added testing for updating project configs via PATCH in |
ru-fu
added a commit
to ru-fu/lxd
that referenced
this pull request
Jul 22, 2024
The functionality was fixed in canonical#13786 Signed-off-by: Ruth Fuchss <[email protected]>
tomponline
added a commit
that referenced
this pull request
Jul 22, 2024
The functionality was fixed in #13786
tomponline
pushed a commit
to tomponline/lxd
that referenced
this pull request
Jul 23, 2024
The functionality was fixed in canonical#13786 Signed-off-by: Ruth Fuchss <[email protected]>
hamistao
pushed a commit
to hamistao/lxd
that referenced
this pull request
Jul 23, 2024
The functionality was fixed in canonical#13786 Signed-off-by: Ruth Fuchss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides an update to the logic for patching project configurations. Previously, there was an overwrite of the existing project config such that it was updated to consist solely of the data in the patch. With this update we maintain existing key/value pairs, and only overwrite those also present in the patch.
Closes #13632.