add support for local registry discovery #1437
Conversation
|
|
||
| # If no local-registry-hosting documentation has been installed, | ||
| # install a help guide that points to the microk8s registry docs. | ||
| if [ $installed_registry_help -eq 0 ] && |
There was a problem hiding this comment.
I put this code in the apiservice-kicker, because it needs to happen after the apiservice comes up.
This seemed like the best fit for that kind of a life-cycle hook in the current code (even if the fit isn't that great)
But I'm completely open to suggestions on better places to put it!
There was a problem hiding this comment.
Indeed we do not have a place to put any maifests we want to apply at boot time.
As you said, it is good enough for now. We will explore alternatives if this causes problems.
|
@nicks is there any doc/blog post we could supplement the 1.19 release announcement regarding this feature and push to our social channels? Thanks. |
|
@ktsakalozos Not a lot right now aside from https://docs.tilt.dev/choosing_clusters.html#discovering-the-registry and the KEP itself (https://github.com/kubernetes/enhancements/tree/master/keps/sig-cluster-lifecycle/generic/1755-communicating-a-local-registry) I'm hoping to get a few more implementations in the field and then write about it more on our blog |
Fixes #1173