Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[snap] drop packaged libssh #2501

Merged
merged 2 commits into from
Mar 31, 2022
Merged

[snap] drop packaged libssh #2501

merged 2 commits into from
Mar 31, 2022

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Mar 30, 2022

We build our own.

@Saviq
[snap] drop packaged libssh
2cc0c28 
We build our own.
@codecov
Copy link

codecov bot commented Mar 30, 2022 •
edited
Loading

Codecov Report

Merging #2501 (c4ddeda) into main (523467c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2501   +/-   ##
=======================================
  Coverage   85.41%   85.41%           
=======================================
  Files         206      206           
  Lines       10258    10258           
=======================================
  Hits         8762     8762           
  Misses       1496     1496

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523467c...c4ddeda. Read the comment docs.

@Saviq
Copy link
Collaborator Author

Saviq commented Mar 30, 2022

bors try

bors bot added a commit that referenced this pull request Mar 30, 2022
@bors
Try #2501:
0901b56
@bors
Copy link
Contributor

bors bot commented Mar 30, 2022

try

Build succeeded:

@Saviq Saviq marked this pull request as ready for review March 30, 2022 14:27
townsend2010
townsend2010 reviewed Mar 30, 2022
View reviewed changes
Copy link
Contributor

@townsend2010 townsend2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see libssh.so.4.8.4 in the snap. I don't think it breaks anything, but if we are doing this exercise, it should go away. That said, it may not be trivial to get Snapcraft to remove it, so not going to block this.

@Saviq
[snap] put libvirt into a separate part
c4ddeda 
This way we can avoid staging extra libssh.
@Saviq
Copy link
Collaborator Author

Saviq commented Mar 31, 2022

bors try

@bors
Copy link
Contributor

bors bot commented Mar 31, 2022

🔒 Permission denied

Existing reviewers: click here to make Saviq a reviewer

@Saviq
Copy link
Collaborator Author

Saviq commented Mar 31, 2022

How about now?

bors try

bors bot added a commit that referenced this pull request Mar 31, 2022
@bors
Try #2501:
4e6ac49
@Saviq
Copy link
Collaborator Author

Saviq commented Mar 31, 2022

Just for a confirmation on libvirt:

$ sudo multipass get local.driver
libvirt
$ multipass list
Name                    State             IPv4             Image
primary                 Running           192.168.122.18   Ubuntu 20.04 LTS

@bors
Copy link
Contributor

bors bot commented Mar 31, 2022

try

Build failed:

townsend2010
townsend2010 reviewed Mar 31, 2022
View reviewed changes
Copy link
Contributor

@townsend2010 townsend2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline question below.

snap/snapcraft.yaml Show resolved Hide resolved
townsend2010
townsend2010 approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@townsend2010 townsend2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, great, thanks!

bors merge

@bors
Copy link
Contributor

bors bot commented Mar 31, 2022

Build failed:

@Saviq Saviq merged commit 2bd4f0a into main Mar 31, 2022
@bors bors bot deleted the fix-snap-libssh branch March 31, 2022 15:34
townsend2010 pushed a commit that referenced this pull request Apr 1, 2022
@bors @Saviq
Merge #2501
04e36f2 
2501: [snap] drop packaged libssh r=townsend2010 a=Saviq

We build our own.

Co-authored-by: Michał Sawicz <[email protected]>
townsend2010 pushed a commit that referenced this pull request Apr 7, 2022
@bors @Saviq
Merge #2501
b94a53b 
2501: [snap] drop packaged libssh r=townsend2010 a=Saviq

We build our own.

Co-authored-by: Michał Sawicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@townsend2010 townsend2010 townsend2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saviq @townsend2010