Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Unfortunately,
publish_charm
from operator-workflows does not work for NetBox. The main reason is that we used charmcraft build from a branch (last valid one is this one), and the actioncanonical/charming-actions/upload-charm
does not build charmcraft from source.The workflow was created manually before the operator-workflow refactor for better-build. Now it has to be fixed again.
However, as charmcraft Django extension should be merged soon (see this PR), I believe it is better to just publish the charm manually until that is merged, instead of rewriting again the publish_charm action to change it again when charmcraft is merged.
Uploading the charm manually is done with:
Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
src-docs
urgent
,trivial
,complex
)