Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt netbox to paas-app-charmer 1.3.1 #38

Merged
merged 8 commits into from
Oct 11, 2024

Conversation

javierdelapuente
Copy link
Collaborator

@javierdelapuente javierdelapuente commented Oct 9, 2024

Overview

Several minor tasks have been done in this PR:

  • Update version of paas-app-charmer used to 1.3.1
    • Remove all customisations in charm.py.
      • netbox-rq is now a worker service.
      • cron is run as a scheduler
  • Upgrade all libraries and get net libraries.
  • Upgrade integrations tests and cloud init tutorial to use juju 3.5 and microk8s 1.31.
  • Fix release github action.

For cron processes, output is redirected now to /proc/$(pgrep cron -U 0 -P 1)/fd/2, so it gets sent to loki. I could not find a cleaner way (/proc/1/fd/2 it an invalid symlink and /dev/pts/X is not always the same number, a machine sshing there could get another value).

The "readiness" check has been removed for now. The reason is that it is useless (the ingress relation does not update the endpoints with it).

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@javierdelapuente javierdelapuente added bug Something isn't working trivial labels Oct 9, 2024
@javierdelapuente javierdelapuente marked this pull request as ready for review October 9, 2024 14:37
@javierdelapuente javierdelapuente requested a review from a team as a code owner October 9, 2024 14:37
@javierdelapuente javierdelapuente removed the bug Something isn't working label Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Test coverage for b755306

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py       7      1      2      1    78%   20
----------------------------------------------------------
TOTAL              7      1      2      1    78%

Static code analysis report

Run started:2024-10-09 15:04:55.279599

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 660
  Total lines skipped (#nosec): 1
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Copy link

@jdkandersson jdkandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@javierdelapuente javierdelapuente merged commit 9ca5a43 into main Oct 11, 2024
17 checks passed
@javierdelapuente javierdelapuente deleted the adapt-to-last-paas-app-charmer branch October 11, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants