Don't use Files.createTempFile() while loading libjssl.so #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During initialization of OpenSSLFIPSProvider, we load libjssl.so shipped as a resource from the jar file built by maven. We create a temporary file, copy the resource into it and call System.loadLibrary() on the temporary file. The Files.createTempFile() method needs a SecureRandom. If OpenSSLFIPSProvider is configured as the provider with top priority, this will attempt to initialize OpenSSLDRBG causing a recursive attempt to load libjssl.so and failing with an NPE. This commit removes the use of Files.createTempFile() to make sure no other security function is not invoked while loading libjssl.so during initialization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During initialization of OpenSSLFIPSProvider, we load libjssl.so shipped as a resource from the jar file built by maven. We create a temporary file, copy the resource into it and call System.loadLibrary() on the temporary file.
The Files.createTempFile() method needs a SecureRandom. If OpenSSLFIPSProvider is configured as the provider with top priority, this will attempt to initialize OpenSSLDRBG causing a recursive attempt to load libjssl.so and failing with an NPE.
This commit removes the use of Files.createTempFile() to make sure no other security function is not invoked while loading libjssl.so during initialization.