fix(enter): block --verbose for exec subcommand

[rebornplusplus]

NOTE: do not merge until canonical/rockcraft#495 is finalized.

This PR blocks the usage of --verbose option in "enter" command whenever the "exec" subcommand follows. Thus, the following will result in errors:

pebble enter --verbose [enter-OPTS*] exec [exec-OPTS] <cmd..>

Everything else, however, are kept unchanged. So the following is okay:

pebble enter [enter-OPTS*] exec [exec-OPTS] <cmd..>

Note that enter-OPTS* refer to all "enter" options except -v, --verbose.

Resolves #339.

[rebornplusplus]

@linostar, please let me know if this PR should block on any Rockcraft decisions.

[linostar]

@linostar, please let me know if this PR should block on any Rockcraft decisions.

Please hold until canonical/rockcraft#495 is finalised.

[benhoyt]

For my benefit, what controls which version of Pebble is baked into a Rock? Is that dependent on the Rockcraft version, that is, Rockcraft version X corresponds to Pebble version Y?

[rebornplusplus]

It's always the latest stable snap of pebble: https://github.com/canonical/rockcraft/blob/main/rockcraft/pebble.py#L167-L180

    PEBBLE_PATH = "var/lib/pebble/default"
    PEBBLE_LAYERS_PATH = f"{PEBBLE_PATH}/layers"
    PEBBLE_BINARY_PATH = "bin/pebble"
    PEBBLE_PART_SPEC = {
        "plugin": "nil",
        "stage-snaps": ["pebble/latest/stable"],
        "stage": [PEBBLE_BINARY_PATH],
        # We need this because "services" is Optional, but the directory must exist
        "override-prime": str(
            "craftctl default\n"
            f"mkdir -p {PEBBLE_LAYERS_PATH}\n"
            f"chmod 777 {PEBBLE_PATH}"
        ),
    }

[benhoyt]

Approved with two nit suggestions (though we won't merge until l canonical/rockcraft#495 is ready).

[rebornplusplus]

Thanks! I have updated the error messages. But yes, let's please hold this until canonical/rockcraft#495 is ready.

[cjdcordeiro]

@rebornplusplus why do we need to wait for canonical/rockcraft#495?

[rebornplusplus]

@rebornplusplus why do we need to wait for canonical/rockcraft#495?

Since rockcraft fetches the latest pebble binary/snap, docker run <rock> exec <cmd> would fail if --verbose is not removed from the rock's entrypoint.

[cjdcordeiro]

y true. thanks

[benhoyt]

Now that canonical/rockcraft#495 is merged, can we merged this? (We won't release a new Pebble version till the end of June, though.) Or do we need to wait till a new version of rockcraft is shipped?

[cjdcordeiro]

We better wait for a new rockcraft release, otherwise, there's a chance this change gets to stable before rockcraft, and those using rockcraft will immediately become unable to run the exec command for their rocks.

@tigarmo what's the planned date for releasing a new v of rockcraft?

[cjdcordeiro]

rockcraft 1.4.0 is now in stable. Let's allow for a graceful week and merge this on the 27th.

[benhoyt]

Sounds good, thanks @cjdcordeiro!

[cjdcordeiro]

We should be good to go on this @benhoyt ! Thanks for waiting