Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use RFC2602 domain (example.com) in custom notice examples #407

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

benhoyt
Copy link
Contributor

@benhoyt benhoyt commented Apr 9, 2024

Also use consistent "/path" to indicate it can be a path (with multiple segments).

This is per Tony's comment at canonical/operator#1170 (comment)

Also use consistent "/path" to indicate it can be a path (with
multiple segments).
@benhoyt benhoyt changed the title chore: use RFC2602 reserved domain (example.com) in custom notice examples chore: use RFC2602 domain (example.com) in custom notice examples Apr 9, 2024
@benhoyt benhoyt requested a review from tonyandrewmeyer April 9, 2024 04:44
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@benhoyt benhoyt merged commit 18c93cb into canonical:master Apr 9, 2024
15 checks passed
@benhoyt benhoyt deleted the fix-domain-examples branch April 9, 2024 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants