Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a new basic type identity #563

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

IronCore864
Copy link
Contributor

@IronCore864 IronCore864 commented Jan 23, 2025

A new "basic" type of identity and "metrics" type of access are added for the upcoming metrics feature.

To expose the upcoming metrics feature over HTTP, we need a certain level of authentication to protect the endpoint. We decided to use HTTP basic authentication for this purpose. A new type of "basic" identity needs to be implemented for this to work, and the access level would be metrics. The basic identity looks like this:

identities:
  bob:
    access: metrics
    basic:
      password: hashed-password-with-salt

Where the password is generated by openssl passed -6. The hashed password will be stored in the state, and when the user accesses the metrics endpoint, they need to set the Authorization header accordingly. Pebble daemon will sha512 hash the password and compare it to the identity stored in the state.

For more details, see the spec here.

@IronCore864 IronCore864 requested a review from benhoyt January 23, 2025 01:51
@IronCore864 IronCore864 marked this pull request as ready for review January 23, 2025 01:51
@benhoyt
Copy link
Contributor

benhoyt commented Jan 24, 2025

Let's please add a few more details about the feature to the PR description, and link to the spec (internal, I know).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants