Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPE-6344] LDAP II: Include charm libs #883

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sinclert-canonical
Copy link
Contributor

@sinclert-canonical sinclert-canonical commented Mar 6, 2025

This is the 2nd PR to introduce LDAP support into PostgreSQL. The complete list of changes can be seen in this branch.

Contents

This PR introduces the ldap V0 charm library, as well as the certificate-transfer V0 charm library. Despite having V1 of the latter already published, V0 requires jsonschema instead of pydantic which plays nicely with the version of the TLS charm lib we are using (see code). I would say whenever we bump one, we bump the other.

References

@sinclert-canonical sinclert-canonical added the enhancement New feature, UI change, or workload upgrade label Mar 6, 2025
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.21%. Comparing base (e1684df) to head (e5c3a74).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #883   +/-   ##
=======================================
  Coverage   75.21%   75.21%           
=======================================
  Files          12       12           
  Lines        3187     3187           
  Branches      477      477           
=======================================
  Hits         2397     2397           
  Misses        643      643           
  Partials      147      147           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, UI change, or workload upgrade Libraries: Out of sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant