-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(WIP) [DPE-5303] Update endpoints faster when snap is stopped #610
base: main
Are you sure you want to change the base?
(WIP) [DPE-5303] Update endpoints faster when snap is stopped #610
Conversation
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (30.30%) is below the target coverage (33.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
==========================================
- Coverage 70.81% 70.60% -0.21%
==========================================
Files 12 12
Lines 3039 3055 +16
Branches 537 542 +5
==========================================
+ Hits 2152 2157 +5
- Misses 771 782 +11
Partials 116 116 ☔ View full report in Codecov by Sentry. |
…er-from-snap-service-stop Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Signed-off-by: Marcelo Henrique Neppel <[email protected]>
…er-from-snap-service-stop Signed-off-by: Marcelo Henrique Neppel <[email protected]>
Issue
If the snap services are stopped manually by calling
snap stop charmed.postgresql
, the endpoints are not updated in thedatabase
relation endpoint, causing errors in the client charm side.Solution
Improve the Cluster Topology Observer to check other members' REST API when the current member's REST API is not accessible.
This will allow the endpoint to be changed to the IP of the new primary before the
update-status
hook is called the next time.I'm still working on making this more robust.