interfaces/desktop: allow DBus access to plasmashell #13737
Conversation
apparmor in Ubuntu 24.04 LTS introduces an AppArmor profile for KDEs plasmashell called "plasmashell". As such, the DBus Notifications object is now implemented by a process that has the apparmor label "plasmashell" instead of "unconfined" (since previously it did not have an AppArmor profile). Extend the DBus rules for /org/freedesktop/Notifications to include this new peer label to allow snaps to send notifications as before. Fixes part of LP: #2056696 Signed-off-by: Alex Murray <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #13737 +/- ##
==========================================
- Coverage 78.90% 78.90% -0.01%
==========================================
Files 1043 1043
Lines 134337 134350 +13
==========================================
+ Hits 106004 106013 +9
- Misses 21721 21722 +1
- Partials 6612 6615 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
NOTE: Needs additional work to fully solve the LP bug |
|
To clarify the comment from @ernestl above - the LP bug mentions two issues - one for desktop notifications, and the other from system tray access - this PR solves the first issue. A subsequent PR will be sent if/when I can reproduce the issue around the system tray. So this PR can be considered complete in its own right (but just not sufficient to completely resolve that single LP bug). |
apparmor in Ubuntu 24.04 LTS introduces an AppArmor profile for KDEs plasmashell called "plasmashell". As such, the DBus StatusNotifierItem object is now implemented by a process that has the apparmor label "plasmashell" instead of "unconfined" (since previously it did not have an AppArmor profile). Extend the DBus rules which allow access to /StatusNotifierItem to include this new peer label to allow snaps to correctly register their app tray icons etc as before. Fixes the other part of LP: #2056696 Signed-off-by: Alex Murray <[email protected]>
apparmor in Ubuntu 24.04 LTS introduces an AppArmor profile for KDEs plasmashell called "plasmashell". As such, the DBus Notifications, StatusNotifierItem and dbusmenu objects are now implemented by a process that has the apparmor label "plasmashell" instead of "unconfined" (since previously it did not have an AppArmor profile). Extend the DBus rules which allow access to these objects to include this new peer label to allow snaps to correctly register their app tray icons etc as before. Fixes another part of LP: #2056696 Signed-off-by: Alex Murray <[email protected]>
|
Added two additional commits which resolve the remaining issues from the Launchpad bug. This is now ready for review and merging. |
alexmurray
changed the title
Similar to canonical#13737. Amending this makes mpris work again in plasma.
Similar to #13737. Amending this makes mpris work again in plasma.
apparmor in Ubuntu 24.04 LTS introduces an AppArmor profile for KDEs plasmashell
called "plasmashell". As such, the various DBus objects are now implemented
by a process that has the apparmor label "plasmashell" instead of
"unconfined" (since previously it did not have an AppArmor profile).
Extend the DBus rules for these objects to include this new
peer label to allow snaps to send notifications as before.
Fixes LP: #2056696
Signed-off-by: Alex Murray [email protected]