many: add passphrase authentication support v2 #14954
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeyadYasser
added
Needs Samuele review
ZeyadYasser
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## fde-manager-features #14954 +/- ##
=======================================================
Coverage ? 78.15%
=======================================================
Files ? 1167
Lines ? 155089
Branches ? 0
=======================================================
Hits ? 121208
Misses ? 26368
Partials ? 7513
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bboozzoo
reviewed
Jan 22, 2025
|
we might want to get the branch in shape for merging before considering landing this |
|
@bboozzoo I had to revert the suggestion from #14918 (comment) because internally secboot actually closes the passed TPM connection, and since keys for both data and save partitions are created we need a new TPM connection for each. My bad for not remembering this when addressing the comment. |
pedronis
force-pushed
the
fde-manager-features
branch
from
7005c64 to
25f9119
Compare
Signed-off-by: Zeyad Gouda <[email protected]>
Signed-off-by: Zeyad Gouda <[email protected]>
Signed-off-by: Zeyad Gouda <[email protected]>
Signed-off-by: Zeyad Gouda <[email protected]>
Signed-off-by: Zeyad Gouda <[email protected]>
… context Internally the secboot library closes the passed TPM connection, until this is fixed, a separate connection per newTPMProtectedKey call fixes this issue. Signed-off-by: Zeyad Gouda <[email protected]>
Signed-off-by: Zeyad Gouda <[email protected]>
ZeyadYasser
force-pushed
the
fde-passphrase-support-v2
branch
from
a9c0ef2 to
23a6d7c
Compare
|
Rebased on top of latest fde branch, and updated secboot to include the double TPM connection fix |
|
Removed blocked label since now fde branch is in a more stable state |
|
added blocked label again, as agreement was to merge into master directly |
|
Wed Jan 29 15:48:26 UTC 2025 Failures:Preparing:
Executing:
Restoring:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a re-implementation of #14918 with suggestion from @valentindavid #14918 (review) of not having volumes authentication options attached to the bootstrapped containers but rather passed along with the rest of other FDE params. A followup PR could be created to tidy up the passed FDE parameters (e.g. data/save bootstrap containers, primary key, volume auth options).
This PR implements passphrase authentication support during installation. Currently all volumes created during installation are passphrase encrypted, i.e.
ubuntu-dataandubuntu-save.Note: This is still not exposed through the API until target system (#14943) and entropy checks are added. This is done by not including
passphrase-authin the list of supported encryption features (Check SD201).The TPM connection workaround can be removed once canonical/secboot#360 lands.