tests: add remodeling test using fakestore #14955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentindavid
added
Run nested
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fde-manager-features #14955 +/- ##
=======================================================
Coverage ? 78.16%
=======================================================
Files ? 1168
Lines ? 155000
Branches ? 0
=======================================================
Hits ? 121151
Misses ? 26337
Partials ? 7512
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Same comments as for #14851 - anyway, I think that for the future repack-kernel.sh and the steps taken when preparing should be scripts in $TESTLIB, but of course that is a TODO for later, when the branch in finally merged to master.
valentindavid
force-pushed
the
valentindavid/lost-commit
branch
from
51ac448 to
55e15ed
Compare
pedronis
merged commit ff98281
into
canonical:fde-manager-features
54 of 59 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was merged in #14305
But it disappeared, probably during a rebase.