data, packaging: separate check and implicit build makefile targets #14964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a separate check target in the top level Makefile and run check for data/systemd, which is the only directory where checks are implemented. Signed-off-by: Maciej Borzecki <[email protected]>
Signed-off-by: Maciej Borzecki <[email protected]>
Signed-off-by: Maciej Borzecki <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14964 +/- ##
=========================================
Coverage ? 78.28%
=========================================
Files ? 1158
Lines ? 153446
Branches ? 0
=========================================
Hits ? 120123
Misses ? 25918
Partials ? 7405
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zyga
approved these changes
Jan 23, 2025
|
Thu Jan 23 12:03:12 UTC 2025 Failures:Preparing:
Restoring:
|
ZeyadYasser
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building from AUR it is surprisingly common to not perform the builds in chroots or allow one's PATH to leak into the build environment. Turns out, if one has shellcheck installed form a snap, it could be picked up by the build and then trip over the sandbox. However, this highlights a separate issue, where running
make -C datainvokes an implicit default target indata/systemdwhich then happens to run checks/tests. Those are normally reserved for (dist)check like targets and expected to be invoked explicitly. The branch introduces a separatechecktarget in top level Makefile underdatawhich subsequently invokescheckfor the sole directly having an implementation.