Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/snap: fix formatting in packCmd struct #14981

Merged

Conversation

olivercalder
Copy link
Member

Trivial fix for formatting problem introduced in #14869.

@olivercalder olivercalder added Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run labels Jan 24, 2025
Copy link
Member

@andrewphelpsj andrewphelpsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it is weird we did not catch this before merging

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@7adb9b7). Learn more about missing BASE report.
Report is 22 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #14981   +/-   ##
=========================================
  Coverage          ?   78.26%           
=========================================
  Files             ?     1160           
  Lines             ?   153708           
  Branches          ?        0           
=========================================
  Hits              ?   120299           
  Misses            ?    26005           
  Partials          ?     7404           
Flag Coverage Δ
unittests 78.26% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Fri Jan 24 22:16:25 UTC 2025

Spread tests skipped

@olivercalder olivercalder merged commit 386592c into canonical:master Jan 24, 2025
66 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly Skip spread Indicate that spread job should not run
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants