Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon: rename confdb API to /v2/confdbs/... #14994

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

miguelpires
Copy link
Contributor

This reverts commit 8a2f81e to make the confdb API singular to give the impression of accessing a single configuration database.

@miguelpires miguelpires added the confdb confdb work (previously called registries and before aspects) label Jan 28, 2025
@github-actions github-actions bot added the Needs Documentation -auto- Label automatically added which indicates the change needs documentation label Jan 28, 2025
Copy link

github-actions bot commented Jan 28, 2025

Wed Jan 29 16:05:07 UTC 2025
The following results are from: https://github.com/canonical/snapd/actions/runs/13028572142

Failures:

Preparing:

  • openstack:debian-12-64:tests/unit/
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64:tests/main/xdg-open-portal

Executing:

  • openstack:debian-12-64:tests/main/refresh:classic_fake
  • openstack:debian-sid-64:tests/main/snap-sign:stdin
  • openstack:opensuse-tumbleweed-64:tests/main/refresh:parallel_strict_fake
  • openstack:opensuse-tumbleweed-64:tests/main/refresh:strict_fake
  • openstack:opensuse-tumbleweed-64:tests/main/refresh:classic_fake
  • openstack:opensuse-tumbleweed-64:tests/main/auto-refresh:parallel
  • openstack:opensuse-tumbleweed-64:tests/main/snap-refresh-hold
  • openstack:opensuse-tumbleweed-64:tests/main/refresh-app-awareness-notify
  • google-arm:ubuntu-core-22-arm-64:tests/core/gadget-update-pc
  • google-core:ubuntu-core-22-64:tests/core/mem-cgroup-disabled
  • google:ubuntu-25.04-64:tests/main/lxd-mount-units

Restoring:

  • openstack:debian-sid-64:tests/unit/
  • openstack:debian-12-64:tests/unit/
  • openstack:debian-12-64:tests/unit/
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64
  • openstack:opensuse-tumbleweed-64:tests/main/refresh-app-awareness-notify
  • openstack:opensuse-tumbleweed-64:tests/main/
  • openstack:opensuse-tumbleweed-64
  • google-arm:ubuntu-core-22-arm-64:tests/core/gadget-update-pc
  • google-arm:ubuntu-core-22-arm-64:tests/core/
  • google-arm:ubuntu-core-22-arm-64
  • google-core:ubuntu-core-22-64:tests/core/mem-cgroup-disabled
  • google-core:ubuntu-core-22-64:tests/core/
  • google-core:ubuntu-core-22-64

@miguelpires miguelpires changed the title Revert "daemon: rename confdb API to /v2/confdbs/..." daemon: rename confdb API to /v2/confdbs/... Jan 28, 2025
Copy link
Contributor

@ZeyadYasser ZeyadYasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@andrewphelpsj andrewphelpsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@miguelpires miguelpires reopened this Jan 28, 2025
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@23039ca). Learn more about missing BASE report.
Report is 50 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #14994   +/-   ##
=========================================
  Coverage          ?   78.25%           
=========================================
  Files             ?     1159           
  Lines             ?   153934           
  Branches          ?        0           
=========================================
  Hits              ?   120455           
  Misses            ?    26066           
  Partials          ?     7413           
Flag Coverage Δ
unittests 78.25% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ernestl ernestl merged commit 3e93828 into canonical:master Jan 29, 2025
62 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confdb confdb work (previously called registries and before aspects) Needs Documentation -auto- Label automatically added which indicates the change needs documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants