overlord/fdestate: mock amd64 architecture in unit tests #14999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bboozzoo
added
Simple 😃
ZeyadYasser
approved these changes
Jan 29, 2025
pedronis
force-pushed
the
fde-manager-features
branch
from
7005c64 to
25f9119
Compare
Mock the architecture so that boot assets can be properly identified even when running unit tests on ARM64. Signed-off-by: Maciej Borzecki <[email protected]>
bboozzoo
force-pushed
the
bboozzoo/fde-unit-test-on-arm-assets
branch
from
5c115c4 to
1a98f00
Compare
valentindavid
approved these changes
Jan 29, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fde-manager-features #14999 +/- ##
========================================================
- Coverage 78.20% 77.85% -0.35%
========================================================
Files 1171 1175 +4
Lines 155885 155856 -29
========================================================
- Hits 121903 121344 -559
- Misses 26450 26993 +543
+ Partials 7532 7519 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Wed Jan 29 15:46:10 UTC 2025 Failures:Preparing:
Restoring:
|
bboozzoo
merged commit 74f68d8
into
canonical:fde-manager-features
65 of 67 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mock the architecture so that boot assets can be properly identified even when running unit tests on ARM64.