[DPE-2123] Ensure feature parity between kubectl and lightkube backends and add integration tests. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output produced from the program are presented to the user by writing directly the stdout (via print function). Also, the debug information should not appear as output to the user's console. For that, the log level of logs written in a few places have been demoted.
If no namespace is provided explicitly, for both backends, all service accounts in all namespaces that have the custom labels provided by this tool should be listed. Earlier, only the accounts in the `default` namespace were listed when no `--namespace` option was provided. This is done for the `lightkube` backend to be consistent with the `kubectl` backend, because `kubectl` lists all accounts in all namespaces by default.
For lightkube backend, the behavior should be the same as it exists in kubectl backend.
Since this information is only relevant for debugging purposes, this should not be a warning log.
Added new test cases for deletion of service account, adding config, removing config, clearing config, get primary and get config commands.
This needs to be done to ensure the service account, role and role binding to be created as part of creation of service account do not exist already in the Kubernetes cluster. If such scenario happens, then the program would crash with exception, while it may have created some resources already but still not able to create all of the resources.
Test the behavior of creation when the service account about to be created already exists in Kubernetes cluster.
theoctober19th
changed the title
deusebio
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Great job @theoctober19th ! I have some suggestions comments here and there, but overall I really liked the PR, and I don't have major concerns.
Just run through the suggestions with @welpaolo and you are free to decide the way forward
Thanks!
theoctober19th
changed the title
welpaolo
approved these changes
Jan 11, 2024
theoctober19th
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
kubectlandlightkubebackends consistent on all service account registry commands.Jira:
DPE-2123