Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-2164] Expose Spark SQL CLI #66

Merged
merged 6 commits into from
Feb 16, 2024
Merged

[DPE-2164] Expose Spark SQL CLI #66

merged 6 commits into from
Feb 16, 2024

Conversation

theoctober19th
Copy link
Member

@theoctober19th theoctober19th commented Feb 8, 2024 •
edited
Loading

This PR adds Spark SQL CLI to the spark8t library.

@theoctober19th theoctober19th marked this pull request as ready for review February 15, 2024 15:49
welpaolo
welpaolo approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@welpaolo welpaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

deusebio
deusebio approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@deusebio deusebio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually we should factor the boiler plate of merging configuration in a single place. It seems a bit copy and paste at this point.

But I'm happy to do this in another PR, and not block this feature.

@theoctober19th theoctober19th merged commit 8eec7ca into canonical:main Feb 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deusebio deusebio deusebio approved these changes

@welpaolo welpaolo welpaolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theoctober19th @welpaolo @deusebio